Improves DX for containers #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the spec-workflow-mcp container setup to use runtime user/group ID mapping via the --user flag, replacing the previous build-time user configuration. The changes include a new automated setup script, updated documentation, and Dockerfile modifications to support this new approach.
Key changes:
- Introduces an automated setup script (
setup-mcp.sh) that detects user/group IDs and configures.mcp.jsonautomatically - Updates Dockerfile to make application files world-readable and removes fixed user configuration, enabling runtime user mapping
- Updates documentation to reflect the new configuration approach with full project directory mounting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| containers/setup-mcp.sh | New automated setup script that configures .mcp.json with proper user/group IDs and manages .spec-workflow directory permissions |
| containers/README.md | Updated documentation to include automated setup instructions and clarify the new runtime user mapping approach |
| containers/Dockerfile | Modified to remove fixed user configuration, make files world-readable, and support runtime --user flag usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had permissions issues in some scenarios and wasn't portable.
This PR introduces a shell script for adding the docker container to
.mcp.jsonby manipulating an existing file, or creating a new.mcp.jsonfile. The script is run in the project directory and determines the correct uid and gid for the container to run and all the necessary paths.The user cd's to their project directory runs, e.g.
~/spec-workflow-mcp/containers/setup-mcp.shand they should be good to go.I've been using this successfully for a week or so. Works well in my experience.